kernels-data: allow unknown fields in Metadata#481
Merged
Conversation
Now that we will use `kernels-data` inside `kernels`, we have to allow unknown fields in metadata. Otherwise the following scenario will break: 1. We publish kernels 0.14. 2. We add a field `foo` to the metadata in kernel-builder 0.15. 3. `kernels` 0.14 will not load metadata from kernel-builder 0.15, since it contains an unknown (for 0.14) field `foo`.
drbh
previously approved these changes
Apr 17, 2026
Collaborator
drbh
left a comment
drbh
left a comment
There was a problem hiding this comment.
approving but we'll need to update the test case
drbh
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we will use
kernels-datainsidekernels, we have to allowunknown fields in metadata. Otherwise the following scenario will break:
footo the metadata in kernel-builder 0.15.kernels0.14 will not load metadata from kernel-builder 0.15,since it contains an unknown (for 0.14) field
foo.